This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((benil() < ni && seso || mi) && (piaxo() || urkSle() <= thie && peiang())) {
...
...
// Pretend there is lots of code here
...
...
} else {
sught();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!peiang() || urkSle() >= thie) && !piaxo() || !mi && (!seso || benil() > ni)) {
sught();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!twel && erlist() && !eou && !as && to) {
if (to) {
return true;
}
if (!as) {
return true;
}
if (!eou) {
return true;
}
if (spipse()) {
return true;
}
}
if (erm) {
return true;
}
return false;
return erm && (spipse() || !twel && erlist()) && !eou && !as && to;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!erlist() && !spipse() || twel && !spipse() || !erm) {
if (eou) {
if (as) {
if (!to) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (an == true) {
jisPusel();
} else if (bi == true && an != true) {
ceden();
}
if (ac == 9 && an != true && bi != true) {
hecDahas();
} else if (ir == 1 && an != true && bi != true && ac != 9) {
dasso();
} else if (vo == false && an != true && bi != true && ac != 9 && ir != 1) {
cosvas();
} else if (an != true && bi != true && ac != 9 && ir != 1 && vo != false) {
prapa();
}
{
if (an) {
jisPusel();
}
if (bi) {
ceden();
}
if (ac == 9) {
hecDahas();
}
if (ir == 1) {
dasso();
}
if (!vo) {
cosvas();
}
prapa();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: