This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(ka == hiom || nur == sa || ang || acil() >= crouce()) && uasm() != ie || !cred) {
...
...
// Pretend there is lots of code here
...
...
} else {
saso();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (cred && (uasm() == ie || ka == hiom || nur == sa || ang || acil() >= crouce())) {
saso();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (i || ec || silfud() == evosm() && ep || foreng() > 2 || iant()) {
if (a) {
return true;
}
}
return false;
return a || i || ec || silfud() == evosm() && ep || foreng() > 2 || iant();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (silfud() != evosm() && !ec && !i && !a) {
if (!a) {
return false;
}
if (!i) {
return false;
}
if (!ec) {
return false;
}
if (!ep) {
return false;
}
}
if (foreng() < 2) {
return false;
}
if (!iant()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (e >= 1) {
palqe();
} else if (va == true && e <= 1) {
etwan();
} else if (hian != 3 && e <= 1 && va != true) {
mache();
} else if (xid == true && e <= 1 && va != true && hian == 3) {
iasRish();
} else if (mi == true && e <= 1 && va != true && hian == 3 && xid != true) {
ossphe();
}
if (ced == true && e <= 1 && va != true && hian == 3 && xid != true && mi != true) {
truBiamo();
}
{
if (e >= 1) {
palqe();
}
if (va) {
etwan();
}
if (hian != 3) {
mache();
}
if (xid) {
iasRish();
}
if (mi) {
ossphe();
}
if (ced) {
truBiamo();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: