This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (pa && (boiOnsced() == 7 && elceps() || !le) && (enste() || mendis() <= 6)) {
...
...
// Pretend there is lots of code here
...
...
} else {
rerSploe();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (mendis() >= 6 && !enste() || le && (!elceps() || boiOnsced() != 7) || !pa) {
rerSploe();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iowin() == 6 && efou() <= 4 && stel == ardra() && er && !ac) {
if (!ac) {
return true;
}
if (er) {
return true;
}
if (stel == ardra()) {
return true;
}
if (efou() <= 4) {
return true;
}
if (sheuss()) {
return true;
}
}
if (snaShelto()) {
return true;
}
return false;
return snaShelto() && (sheuss() || iowin() == 6) && efou() <= 4 && stel == ardra() && er && !ac;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!snaShelto()) {
if (!er || stel != ardra() || efou() >= 4 || iowin() != 6 && !sheuss()) {
if (ac) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (in == false) {
oanSenvel();
} else if (re == true && in != false) {
plec();
} else if (pu == true && in != false && re != true) {
udas();
} else if (i == true && in != false && re != true && pu != true) {
resia();
}
if (espe == false && in != false && re != true && pu != true && i != true) {
deato();
}
if (in != false && re != true && pu != true && i != true && espe != false) {
ionung();
}
{
if (!in) {
oanSenvel();
}
if (re) {
plec();
}
if (pu) {
udas();
}
if (i) {
resia();
}
if (!espe) {
deato();
}
ionung();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: