This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((emas() || melk()) && tren == ront && snenai() && !(sioKna() == glul())) {
...
...
// Pretend there is lots of code here
...
...
} else {
issShilga();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (sioKna() == glul() || !snenai() || tren != ront || !melk() && !emas()) {
issShilga();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (co && secric() || gesm() || ioll && secric() || gesm()) {
if (hocsen() < nantwi()) {
if (!de) {
return true;
}
}
}
return false;
return !de || hocsen() < nantwi() || (co || ioll) && (secric() || gesm());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!ioll && !co && hocsen() > nantwi() && de) {
if (de) {
return false;
}
if (hocsen() > nantwi()) {
return false;
}
if (!secric()) {
return false;
}
if (!gesm()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (si == false) {
hossa();
} else if (aspu > 8 && si != false) {
besm();
} else if (ce == false && si != false && aspu < 8) {
eltri();
}
if (ci && si != false && aspu < 8 && ce != false) {
mindo();
} else if (da == false && si != false && aspu < 8 && ce != false && !ci) {
nansur();
}
{
if (!si) {
hossa();
}
if (aspu > 8) {
besm();
}
if (!ce) {
eltri();
}
if (ci) {
mindo();
}
if (!da) {
nansur();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: