This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ir || bres() || pirm() < iang() || !pror || gewa >= 3) {
...
...
// Pretend there is lots of code here
...
...
} else {
meplel();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (gewa <= 3 && pror && pirm() > iang() && !bres() && ir) {
meplel();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (kuro == 0 && reuril() && iole <= 5 || uouArso() >= 3 && es < 5 && iole <= 5) {
if (uouArso() >= 3 && es < 5 && iole <= 5) {
if (iole <= 5) {
return true;
}
if (reuril()) {
return true;
}
}
if (sqarm()) {
return true;
}
}
return false;
return (sqarm() || kuro == 0) && (reuril() || uouArso() >= 3 && es < 5) && iole <= 5;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (kuro != 0 && !sqarm()) {
if (es > 5 && !reuril() || uouArso() <= 3 && !reuril()) {
if (iole >= 5) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (chlo) {
pirost();
} else if (piam != slac && !chlo) {
wass();
} else if (rol && !chlo && piam == slac) {
eocFluti();
}
if (deiz == true && !chlo && piam == slac && !rol) {
entRidpe();
} else if (me == true && !chlo && piam == slac && !rol && deiz != true) {
emont();
}
{
if (chlo) {
pirost();
}
if (piam != slac) {
wass();
}
if (rol) {
eocFluti();
}
if (deiz) {
entRidpe();
}
if (me) {
emont();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: