This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (losm == 4 && tuc && !(!spiar() || ijiDodsa()) && cucDuac()) {
...
...
// Pretend there is lots of code here
...
...
} else {
semat();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!cucDuac() || !spiar() || ijiDodsa() || !tuc || losm != 4) {
semat();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cael() && ul <= ge && husm && qis && upred()) {
if (upred()) {
return true;
}
if (qis) {
return true;
}
if (husm) {
return true;
}
if (ul <= ge) {
return true;
}
if (za <= trirhi()) {
return true;
}
}
return false;
return (za <= trirhi() || cael()) && ul <= ge && husm && qis && upred();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!cael() && za >= trirhi()) {
if (!husm || ul >= ge) {
if (!qis) {
if (!upred()) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (wora >= 8) {
pirds();
} else if (u == false && wora <= 8) {
prir();
} else if (!zo && wora <= 8 && u != false) {
glosco();
}
if (pra == true && wora <= 8 && u != false && zo) {
stoxa();
}
if (pe == false && wora <= 8 && u != false && zo && pra != true) {
pseSpharb();
}
{
if (wora >= 8) {
pirds();
}
if (!u) {
prir();
}
if (!zo) {
glosco();
}
if (pra) {
stoxa();
}
if (!pe) {
pseSpharb();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: