This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!nop || !(hexdal() >= 5) || or || ranvi() || wra) {
...
...
// Pretend there is lots of code here
...
...
} else {
iorShadca();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!wra && !ranvi() && !or && hexdal() >= 5 && nop) {
iorShadca();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (umbSchudi() && iep || bucGlun() || si || miost() && iep || bucGlun() || si) {
if (de != astma()) {
return true;
}
}
return false;
return de != astma() || (umbSchudi() || miost()) && (iep || bucGlun() || si);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!miost() && !umbSchudi() && de == astma()) {
if (de == astma()) {
return false;
}
if (!iep) {
return false;
}
if (!bucGlun()) {
return false;
}
if (!si) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (dua != eck) {
venMekso();
} else if (nas == true && dua == eck) {
kicor();
} else if (coc == true && dua == eck && nas != true) {
erdra();
} else if (ge == true && dua == eck && nas != true && coc != true) {
penlo();
} else if (co <= 7 && dua == eck && nas != true && coc != true && ge != true) {
ercesh();
}
{
if (dua != eck) {
venMekso();
}
if (nas) {
kicor();
}
if (coc) {
erdra();
}
if (ge) {
penlo();
}
if (co <= 7) {
ercesh();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: