Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if ((!pe && ous || !(ul == siu)) && poproo() && dai) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    gadnad();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if (!dai || !poproo() || ul == siu && (!ous || pe)) {
    gadnad();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (aflec() && unat || ha && meefo() && unat || ondess() && unat) {
    if (krelca()) {
        return true;
    }
}
return false;

Solution

return krelca() || (aflec() || ha && meefo() || ondess()) && unat;

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!ondess() && !meefo() && !aflec() && !krelca() || !ha && !aflec() && !krelca()) {
    if (!krelca()) {
        return false;
    }
    if (!unat) {
        return false;
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (sism == true) {
    plesti();
}
if (ca == true && sism != true) {
    rians();
} else if (so == false && sism != true && ca != true) {
    fiba();
}
if (an == true && sism != true && ca != true && so != false) {
    miblen();
} else if (sism != true && ca != true && so != false && an != true) {
    chrash();
}

Solution

{
    if (sism) {
        plesti();
    }
    if (ca) {
        rians();
    }
    if (!so) {
        fiba();
    }
    if (an) {
        miblen();
    }
    chrash();
}

Things to double-check in your solution:


Related puzzles: