This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!rur || pel || pridec() <= e && (be || ledent())) {
...
...
// Pretend there is lots of code here
...
...
} else {
gniErm();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!ledent() && !be || pridec() >= e) && !pel && rur) {
gniErm();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (issthe() && teac() == chea && helos() || trang() && helos() || !mial && helos()) {
if (an) {
return true;
}
}
return false;
return an || issthe() && (teac() == chea || trang() || !mial) && helos();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!issthe() && !an) {
if (mial && !trang() && teac() != chea && !an) {
if (!an) {
return false;
}
if (!helos()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (ond == true) {
sepint();
} else if (io == true && ond != true) {
adil();
} else if (fi == isi && ond != true && io != true) {
rari();
}
if ((ca != 5) == true && ond != true && io != true && fi != isi) {
jolpas();
} else if (ibop == false && ond != true && io != true && fi != isi && (ca != 5) != true) {
eudci();
}
{
if (ond) {
sepint();
}
if (io) {
adil();
}
if (fi == isi) {
rari();
}
if (ca != 5) {
jolpas();
}
if (!ibop) {
eudci();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: