This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (prar == 3 || teong() && ci || chlo == zidSerar() && scic) {
...
...
// Pretend there is lots of code here
...
...
} else {
poast();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!scic || chlo != zidSerar()) && (!ci || !teong()) && prar != 3) {
poast();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (wu && !bix && wil >= ent) {
if (dac) {
if (cobe == 8) {
if (gnaOsm()) {
return true;
}
}
}
}
return false;
return gnaOsm() || cobe == 8 || dac || wu && !bix && wil >= ent;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!wu && !dac && cobe != 8 && !gnaOsm()) {
if (bix && !dac && cobe != 8 && !gnaOsm()) {
if (!gnaOsm()) {
return false;
}
if (cobe != 8) {
return false;
}
if (!dac) {
return false;
}
if (wil <= ent) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (on == true) {
trus();
}
if (so == false && on != true) {
ulbid();
} else if (ed <= qeod && on != true && so != false) {
erfron();
}
if (mai == true && on != true && so != false && ed >= qeod) {
sclist();
} else if (dic == true && on != true && so != false && ed >= qeod && mai != true) {
huhe();
}
{
if (on) {
trus();
}
if (!so) {
ulbid();
}
if (ed <= qeod) {
erfron();
}
if (mai) {
sclist();
}
if (dic) {
huhe();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: