This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((uluc() == 5 || cich() || du != 8 || to) && !neli()) {
...
...
// Pretend there is lots of code here
...
...
} else {
nesstu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (neli() || !to && du == 8 && !cich() && uluc() != 5) {
nesstu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (isas) {
return true;
}
if (ompe) {
return true;
}
if (wa >= giod) {
return true;
}
if (phel()) {
return true;
}
if (mism < 0) {
return true;
}
if (bei) {
return true;
}
return false;
return bei && mism < 0 && phel() && wa >= giod && ompe && isas;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (wa <= giod || !phel() || mism > 0 || !bei) {
if (!ompe) {
if (!isas) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (a == true) {
soregh();
}
if (niip == 1 && a != true) {
rorEkro();
}
if (diou != tia && a != true && niip != 1) {
pumang();
} else if (icio != pa && a != true && niip != 1 && diou == tia) {
epma();
} else if (a != true && niip != 1 && diou == tia && icio == pa) {
iuralf();
}
{
if (a) {
soregh();
}
if (niip == 1) {
rorEkro();
}
if (diou != tia) {
pumang();
}
if (icio != pa) {
epma();
}
iuralf();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: