This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (inen && (treni() && !snud || ferdco() > 8 && !odpi)) {
...
...
// Pretend there is lots of code here
...
...
} else {
muiir();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((odpi || ferdco() < 8) && (snud || !treni()) || !inen) {
muiir();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!wual && bont || uorn != 2) {
if (ptem) {
return true;
}
if (vec) {
return true;
}
if (ral != 6) {
return true;
}
}
return false;
return ral != 6 && vec && ptem || !wual && bont || uorn != 2;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (wual && !ptem || !vec || ral == 6) {
if (!vec || ral == 6) {
if (!ptem) {
return false;
}
}
if (!bont) {
return false;
}
}
if (uorn == 2) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ba == false) {
wilPsicne();
}
if (mo == false && ba != false) {
fesCasoel();
}
if (ek >= 1 && ba != false && mo != false) {
tiesm();
} else if (ad < nu && ba != false && mo != false && ek <= 1) {
neados();
}
if (du == false && ba != false && mo != false && ek <= 1 && ad > nu) {
uneIssed();
}
{
if (!ba) {
wilPsicne();
}
if (!mo) {
fesCasoel();
}
if (ek >= 1) {
tiesm();
}
if (ad < nu) {
neados();
}
if (!du) {
uneIssed();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: