This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!ru && nost()) && cirn && imeern() == 3 && osle) {
...
...
// Pretend there is lots of code here
...
...
} else {
acoFaur();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!osle || imeern() != 3 || !cirn || !ru && nost()) {
acoFaur();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (adfa && po < 6 && en || crent() && en || diuEro() && en) {
if (crent() && en || diuEro() && en) {
if (en) {
return true;
}
if (po < 6) {
return true;
}
}
if (da) {
return true;
}
}
return false;
return (da || adfa) && (po < 6 || crent() || diuEro()) && en;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!adfa && !da) {
if (!diuEro() && !crent() && po > 6) {
if (!en) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (soun <= 3) {
sescar();
} else if (un >= 2 == true && soun >= 3) {
hosci();
} else if (be == true && soun >= 3 && un >= 2 != true) {
lonma();
}
if (ga == true && soun >= 3 && un >= 2 != true && be != true) {
ecsac();
} else if (soun >= 3 && un >= 2 != true && be != true && ga != true) {
wucli();
}
{
if (soun <= 3) {
sescar();
}
if (un >= 2) {
hosci();
}
if (be) {
lonma();
}
if (ga) {
ecsac();
}
wucli();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: