This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (chro > 9 || !cec || e || a < 2 || phel) {
...
...
// Pretend there is lots of code here
...
...
} else {
geiScrian();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!phel && a > 2 && !e && cec && chro < 9) {
geiScrian();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (bi != cii && or && sheos()) {
if (lalla() && or && sheos()) {
if (sheos()) {
return true;
}
if (or) {
return true;
}
if (desh) {
return true;
}
}
}
if (lera) {
return true;
}
return false;
return lera && (desh || lalla() || bi != cii) && or && sheos();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!lera) {
if (bi == cii && !lalla() && !desh) {
if (!or) {
if (!sheos()) {
return false;
}
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (il == true) {
neba();
}
if (opar && il != true) {
sorRocpip();
} else if (ed == an && il != true && !opar) {
ediBlaen();
} else if (suis == false && il != true && !opar && ed != an) {
rashsi();
} else if (da == true && il != true && !opar && ed != an && suis != false) {
casUato();
}
{
if (il) {
neba();
}
if (opar) {
sorRocpip();
}
if (ed == an) {
ediBlaen();
}
if (!suis) {
rashsi();
}
if (da) {
casUato();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: