This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!ci && sepced()) || enhu > 0 || rugo() >= sua || bia == ehot) {
...
...
// Pretend there is lots of code here
...
...
} else {
stiong();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (bia != ehot && rugo() <= sua && enhu < 0 && !ci && sepced()) {
stiong();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ormDinran() && plaul() && eerhic() < 5 || opim() == lidce() && plaul() && eerhic() < 5) {
if (omeEbel() && eerhic() < 5) {
if (eerhic() < 5) {
return true;
}
if (spui) {
return true;
}
}
}
return false;
return (spui || omeEbel() || (ormDinran() || opim() == lidce()) && plaul()) && eerhic() < 5;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!plaul() && !omeEbel() && !spui || opim() != lidce() && !ormDinran() && !omeEbel() && !spui) {
if (eerhic() > 5) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (i == true) {
mised();
}
if (daus == a && i != true) {
dohu();
} else if (an && i != true && daus != a) {
andda();
} else if (roa > 9 && i != true && daus != a && !an) {
psiol();
} else if (i != true && daus != a && !an && roa < 9) {
ebar();
}
{
if (i) {
mised();
}
if (daus == a) {
dohu();
}
if (an) {
andda();
}
if (roa > 9) {
psiol();
}
ebar();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: