This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(asso < ebal()) && !(poc && aurpaf()) && pui || !(omb > pok)) {
...
...
// Pretend there is lots of code here
...
...
} else {
ceglos();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (omb > pok && (!pui || poc && aurpaf() || asso < ebal())) {
ceglos();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (seeac() && mik && fles && borrua() && treCesqi()) {
if (treCesqi()) {
return true;
}
if (borrua()) {
return true;
}
if (fles) {
return true;
}
if (mik) {
return true;
}
if (ti) {
return true;
}
}
return false;
return (ti || seeac()) && mik && fles && borrua() && treCesqi();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!mik || !seeac() && !ti) {
if (!borrua() || !fles) {
if (!treCesqi()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if ((io <= er) == true) {
fostue();
} else if (ahia == 8 && (io <= er) != true) {
scha();
} else if (wrud == true && (io <= er) != true && ahia != 8) {
micTaick();
} else if (so > 5 && (io <= er) != true && ahia != 8 && wrud != true) {
spuUch();
} else if ((io <= er) != true && ahia != 8 && wrud != true && so < 5) {
lulRolead();
}
{
if (io <= er) {
fostue();
}
if (ahia == 8) {
scha();
}
if (wrud) {
micTaick();
}
if (so > 5) {
spuUch();
}
lulRolead();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: