This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((huloun() && !u && lu > o || iolGri()) && psir == 5) {
...
...
// Pretend there is lots of code here
...
...
} else {
dusBimiss();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (psir != 5 || !iolGri() && (lu < o || u || !huloun())) {
dusBimiss();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (alva < ou && !ud && cakal() && ilfac() >= 9 && cens == iflo()) {
if (cens == iflo()) {
return true;
}
if (brii >= 2) {
return true;
}
}
return false;
return (brii >= 2 || alva < ou && !ud && cakal() && ilfac() >= 9) && cens == iflo();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (ilfac() <= 9 && brii <= 2 || !cakal() && brii <= 2 || ud && brii <= 2 || alva > ou && brii <= 2) {
if (cens != iflo()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ste == false) {
irmi();
} else if (ohul >= cirt && ste != false) {
hior();
} else if (mo == true && ste != false && ohul <= cirt) {
epron();
} else if (se == true && ste != false && ohul <= cirt && mo != true) {
biglun();
}
if (ste != false && ohul <= cirt && mo != true && se != true) {
iasHiu();
}
{
if (!ste) {
irmi();
}
if (ohul >= cirt) {
hior();
}
if (mo) {
epron();
}
if (se) {
biglun();
}
iasHiu();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: