This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((ral != 5 || ougos() == ongche()) && o && mouwti() && polco() < 2) {
...
...
// Pretend there is lots of code here
...
...
} else {
treilp();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (polco() > 2 || !mouwti() || !o || ougos() != ongche() && ral == 5) {
treilp();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (edgin() && micPrues() < 1 && sest || asm > grel() || na) {
if (iqaStal()) {
return true;
}
}
return false;
return iqaStal() || edgin() && micPrues() < 1 && (sest || asm > grel() || na);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (micPrues() > 1 && !iqaStal() || !edgin() && !iqaStal()) {
if (!iqaStal()) {
return false;
}
if (!sest) {
return false;
}
if (asm < grel()) {
return false;
}
if (!na) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((mie == 8) == true) {
fiaPlae();
}
if (ploc && (mie == 8) != true) {
codwuc();
}
if (sa == false && (mie == 8) != true && !ploc) {
iangra();
}
if (!doi && (mie == 8) != true && !ploc && sa != false) {
meis();
} else if ((mie == 8) != true && !ploc && sa != false && doi) {
podhil();
}
{
if (mie == 8) {
fiaPlae();
}
if (ploc) {
codwuc();
}
if (!sa) {
iangra();
}
if (!doi) {
meis();
}
podhil();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: