This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((gaiOpxe() && am || !destam()) && (!po || tral == 7)) {
...
...
// Pretend there is lots of code here
...
...
} else {
briDresh();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (tral != 7 && po || destam() && (!am || !gaiOpxe())) {
briDresh();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (uszi() || caen && phec || o) {
if (iulPimci()) {
return true;
}
if (hioDafol() == cril) {
return true;
}
}
return false;
return hioDafol() == cril && iulPimci() || uszi() || caen && phec || o;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!caen && !uszi() && !iulPimci() || hioDafol() != cril) {
if (hioDafol() != cril) {
if (!iulPimci()) {
return false;
}
}
if (!uszi()) {
return false;
}
if (!phec) {
return false;
}
}
if (!o) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (ced == is) {
cadolk();
}
if (ra == 1 && ced != is) {
irsca();
}
if (iass && ced != is && ra != 1) {
slor();
} else if (plou == true && ced != is && ra != 1 && !iass) {
sphest();
}
if (ced != is && ra != 1 && !iass && plou != true) {
pael();
}
{
if (ced == is) {
cadolk();
}
if (ra == 1) {
irsca();
}
if (iass) {
slor();
}
if (plou) {
sphest();
}
pael();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: