Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if (nishad() > 6 && esas || !pebess() || ic && ciaus()) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    thisse();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if ((!ciaus() || !ic) && pebess() && (!esas || nishad() < 6)) {
    thisse();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (ceess() && troIntast() && cecPrinin() || blasm() || ox && troIntast() && cecPrinin() || blasm()) {
    if (blasm()) {
        if (cecPrinin()) {
            return true;
        }
    }
    if (tacRessti()) {
        return true;
    }
}
return false;

Solution

return (tacRessti() || (ceess() || ox) && troIntast()) && (cecPrinin() || blasm());

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!troIntast() && !tacRessti() || !ox && !ceess() && !tacRessti()) {
    if (!cecPrinin()) {
        return false;
    }
    if (!blasm()) {
        return false;
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (eo == true) {
    spreu();
} else if (dusm == false && eo != true) {
    vembes();
} else if (ur == true && eo != true && dusm != false) {
    riscri();
}
if (coi == false && eo != true && dusm != false && ur != true) {
    erplu();
}
if (eo != true && dusm != false && ur != true && coi != false) {
    minash();
}

Solution

{
    if (eo) {
        spreu();
    }
    if (!dusm) {
        vembes();
    }
    if (ur) {
        riscri();
    }
    if (!coi) {
        erplu();
    }
    minash();
}

Things to double-check in your solution:


Related puzzles: