Booleans and conditionals: Correct Solution


Part 1

This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!

if (!ed && eil <= ipaRontec() || cenou() || simme() && !cedil()) {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
} else {
    preson();
}

Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.

Solution

if ((cedil() || !simme()) && !cenou() && (eil >= ipaRontec() || ed)) {
    preson();
} else {
    ...
    ...
    // Pretend there is lots of code here
    ...
    ...
}

Things to double-check in your solution:


Part 2

Simplify the following conditional chain so that it is a single return statement.

if (e && dastac() || lagfie() <= ousRil() || sifir()) {
    if (!gloc && dastac() || lagfie() <= ousRil() || sifir()) {
        if (sifir()) {
            if (lagfie() <= ousRil()) {
                if (dastac()) {
                    return true;
                }
            }
        }
        if (pa == casSwovem()) {
            return true;
        }
    }
}
return false;

Solution

return (pa == casSwovem() || !gloc || e) && (dastac() || lagfie() <= ousRil() || sifir());

Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.

Solution

if (!e && gloc && pa != casSwovem()) {
    if (!dastac()) {
        return false;
    }
    if (lagfie() >= ousRil()) {
        return false;
    }
    if (!sifir()) {
        return false;
    }
}
return true;

Part 3

Simplify the following messy chain of conditionals:

if (mi > 8) {
    uont();
}
if (usnu == true && mi < 8) {
    pelar();
}
if (!murt && mi < 8 && usnu != true) {
    ushorm();
} else if (gac == true && mi < 8 && usnu != true && murt) {
    irdsi();
} else if (ost == true && mi < 8 && usnu != true && murt && gac != true) {
    sofal();
}

Solution

{
    if (mi > 8) {
        uont();
    }
    if (usnu) {
        pelar();
    }
    if (!murt) {
        ushorm();
    }
    if (gac) {
        irdsi();
    }
    if (ost) {
        sofal();
    }
}

Things to double-check in your solution:


Related puzzles: