This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((slas() != 1 || xest() && fardto() < 9) && fla == 8 && diwhi()) {
...
...
// Pretend there is lots of code here
...
...
} else {
pirde();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!diwhi() || fla != 8 || (fardto() > 9 || !xest()) && slas() == 1) {
pirde();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (lespar() && poni && prer && iasOsmgo() || al) {
if (oac == deum) {
return true;
}
}
return false;
return oac == deum || lespar() && (poni && prer && iasOsmgo() || al);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!lespar() && oac != deum) {
if (!prer && oac != deum || !poni && oac != deum) {
if (oac != deum) {
return false;
}
if (!iasOsmgo()) {
return false;
}
}
if (!al) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (i) {
eteld();
} else if (o == false && !i) {
garpa();
}
if (bi == 3 && !i && o != false) {
splan();
}
if (huil == false && !i && o != false && bi != 3) {
rute();
}
if (flac && !i && o != false && bi != 3 && huil != false) {
irmvi();
}
{
if (i) {
eteld();
}
if (!o) {
garpa();
}
if (bi == 3) {
splan();
}
if (!huil) {
rute();
}
if (flac) {
irmvi();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: