This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (a && (twe || scecad() || sorXeci()) && abre()) {
...
...
// Pretend there is lots of code here
...
...
} else {
bles();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!abre() || !sorXeci() && !scecad() && !twe || !a) {
bles();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (chro()) {
if (!epsi && vechid() && ohos() || siu == 0 && vechid() && ohos()) {
if (ea) {
return true;
}
}
}
return false;
return ea || (!epsi || siu == 0) && vechid() && ohos() || chro();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (siu != 0 && epsi && !ea) {
if (!vechid() && !ea) {
if (!ea) {
return false;
}
if (!ohos()) {
return false;
}
}
}
if (!chro()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if ((adi != glou) == true) {
sose();
} else if (cil == true && (adi != glou) != true) {
beiDic();
} else if (!ia && (adi != glou) != true && cil != true) {
nitus();
} else if (thei && (adi != glou) != true && cil != true && ia) {
remui();
}
if ((adi != glou) != true && cil != true && ia && !thei) {
piad();
}
{
if (adi != glou) {
sose();
}
if (cil) {
beiDic();
}
if (!ia) {
nitus();
}
if (thei) {
remui();
}
piad();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: