This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((pha || se) && su && shador() || !peu) {
...
...
// Pretend there is lots of code here
...
...
} else {
nerAslas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (peu && (!shador() || !su || !se && !pha)) {
nerAslas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (o && riin && ucto() == 4) {
if (tiia() && riin && ucto() == 4) {
if (si && riin && ucto() == 4) {
if (ucto() == 4) {
return true;
}
if (riin) {
return true;
}
if (on) {
return true;
}
}
}
}
return false;
return (on || si || tiia() || o) && riin && ucto() == 4;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!riin || !o && !tiia() && !si && !on) {
if (ucto() != 4) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (a == us) {
pelNelun();
}
if (wu > wa && a != us) {
reming();
} else if (ciss && a != us && wu < wa) {
soiosh();
}
if (esh <= oter && a != us && wu < wa && !ciss) {
harLega();
} else if (a != us && wu < wa && !ciss && esh >= oter) {
eisTrang();
}
{
if (a == us) {
pelNelun();
}
if (wu > wa) {
reming();
}
if (ciss) {
soiosh();
}
if (esh <= oter) {
harLega();
}
eisTrang();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: