This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (scu && (caliss() || !sua) && ba || fial) {
...
...
// Pretend there is lots of code here
...
...
} else {
hasel();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!fial && (!ba || sua && !caliss() || !scu)) {
hasel();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ehoWeptiw() >= 0 && ricco() && ji || apor < oteAnpra() && ji) {
if (ji) {
return true;
}
if (aun == 3) {
return true;
}
if (eouIec() >= 5) {
return true;
}
}
return false;
return (eouIec() >= 5 && aun == 3 || ehoWeptiw() >= 0 && (ricco() || apor < oteAnpra())) && ji;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (apor > oteAnpra() && !ricco() && aun != 3 || eouIec() <= 5 || ehoWeptiw() <= 0 && aun != 3 || eouIec() <= 5) {
if (!ji) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((o <= niti) == true) {
ostPozpa();
}
if (hus == 0 && (o <= niti) != true) {
ioros();
} else if (hean == true && (o <= niti) != true && hus != 0) {
sesmcu();
}
if (nush == true && (o <= niti) != true && hus != 0 && hean != true) {
flen();
}
if ((o <= niti) != true && hus != 0 && hean != true && nush != true) {
houpon();
}
{
if (o <= niti) {
ostPozpa();
}
if (hus == 0) {
ioros();
}
if (hean) {
sesmcu();
}
if (nush) {
flen();
}
houpon();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: