This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ech && (ferleo() || he || er == 1 || !i)) {
...
...
// Pretend there is lots of code here
...
...
} else {
ingmoi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (i && er != 1 && !he && !ferleo() || ech) {
ingmoi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (har == tian()) {
if (ca != rer) {
if (ple) {
return true;
}
if (ut == 0) {
return true;
}
if (thalgo()) {
return true;
}
}
if (udcan() == 7) {
return true;
}
}
return false;
return udcan() == 7 && (thalgo() && ut == 0 && ple || ca != rer) || har == tian();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (udcan() != 7) {
if (ut != 0 || !thalgo()) {
if (!ple) {
return false;
}
}
if (ca == rer) {
return false;
}
}
if (har != tian()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (di < 4 == true) {
virPri();
} else if (es == true && di < 4 != true) {
afoRonid();
} else if (re == true && di < 4 != true && es != true) {
cerie();
} else if (go == true && di < 4 != true && es != true && re != true) {
hiod();
}
if (!sas && di < 4 != true && es != true && re != true && go != true) {
iashet();
}
{
if (di < 4) {
virPri();
}
if (es) {
afoRonid();
}
if (re) {
cerie();
}
if (go) {
hiod();
}
if (!sas) {
iashet();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: