This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (kunfe() && tia && (!senol() || !mond) && pacar()) {
...
...
// Pretend there is lots of code here
...
...
} else {
fadchi();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!pacar() || mond && senol() || !tia || !kunfe()) {
fadchi();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (!a && neiod() && epar != 5 && ocir) {
if (ol && neiod() && epar != 5 && ocir) {
if (ocir) {
return true;
}
if (epar != 5) {
return true;
}
if (neiod()) {
return true;
}
if (ga) {
return true;
}
}
}
return false;
return (ga || ol || !a) && neiod() && epar != 5 && ocir;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (epar == 5 || !neiod() || a && !ol && !ga) {
if (!ocir) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if ((beci != 3) == true) {
uaspa();
} else if (bi == false && (beci != 3) != true) {
susbod();
}
if (od && (beci != 3) != true && bi != false) {
erbesm();
}
if (ba == true && (beci != 3) != true && bi != false && !od) {
hiio();
} else if ((beci != 3) != true && bi != false && !od && ba != true) {
gemo();
}
{
if (beci != 3) {
uaspa();
}
if (!bi) {
susbod();
}
if (od) {
erbesm();
}
if (ba) {
hiio();
}
gemo();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: