This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (spuo() > 2 || !iren || roth || i != 0 || iheCak()) {
...
...
// Pretend there is lots of code here
...
...
} else {
debon();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!iheCak() && i == 0 && !roth && iren && spuo() < 2) {
debon();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (iste()) {
if (shocis() != po && !e && sint && gase) {
if (gase) {
return true;
}
if (sint) {
return true;
}
if (!e) {
return true;
}
if (pi == 4) {
return true;
}
}
}
return false;
return (pi == 4 || shocis() != po) && !e && sint && gase || iste();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (shocis() == po && pi != 4) {
if (!sint || e) {
if (!gase) {
return false;
}
}
}
if (!iste()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (nas == a) {
enris();
}
if (!semb && nas != a) {
nidian();
} else if ((ene < 5) == true && nas != a && semb) {
cotbal();
} else if (kun && nas != a && semb && (ene < 5) != true) {
prilac();
}
if (nas != a && semb && (ene < 5) != true && !kun) {
sodcli();
}
{
if (nas == a) {
enris();
}
if (!semb) {
nidian();
}
if (ene < 5) {
cotbal();
}
if (kun) {
prilac();
}
sodcli();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: