This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!er && tocec() && jial && mersa() && cloro()) {
...
...
// Pretend there is lots of code here
...
...
} else {
hapid();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!cloro() || !mersa() || !jial || !tocec() || er) {
hapid();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (el && nirse() || houn && ke || dricec() < egu && nirse() || houn && ke) {
if (houn && ke) {
if (nirse()) {
return true;
}
}
if (a) {
return true;
}
}
return false;
return (a || el || dricec() < egu) && (nirse() || houn && ke);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (dricec() > egu && !el && !a) {
if (!houn && !nirse()) {
if (!nirse()) {
return false;
}
if (!ke) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (oa == false) {
oisBesru();
}
if (vad == true && oa != false) {
threse();
} else if (hooa && oa != false && vad != true) {
speOum();
} else if (be == true && oa != false && vad != true && !hooa) {
phin();
} else if (oa != false && vad != true && !hooa && be != true) {
diiche();
}
{
if (!oa) {
oisBesru();
}
if (vad) {
threse();
}
if (hooa) {
speOum();
}
if (be) {
phin();
}
diiche();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: