This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ston == 0 && (iis == 8 || ea && (ossGicid() || bingbi()))) {
...
...
// Pretend there is lots of code here
...
...
} else {
griFieuz();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!bingbi() && !ossGicid() || !ea) && iis != 8 || ston != 0) {
griFieuz();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (maman() && !ecal || fa || !ac && !ecal || fa || !eack && !ecal || fa) {
if (i) {
return true;
}
}
return false;
return i || (maman() || !ac || !eack) && (!ecal || fa);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (eack && ac && !maman() && !i) {
if (!i) {
return false;
}
if (ecal) {
return false;
}
if (!fa) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (joun == false) {
nerm();
}
if (ai == true && joun != false) {
peva();
} else if (me == true && joun != false && ai != true) {
sustto();
} else if (!eiod && joun != false && ai != true && me != true) {
mepen();
} else if (u == true && joun != false && ai != true && me != true && eiod) {
kurMicec();
}
{
if (!joun) {
nerm();
}
if (ai) {
peva();
}
if (me) {
sustto();
}
if (!eiod) {
mepen();
}
if (u) {
kurMicec();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: