This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((a || oulTrilma()) && frued() && !wel && uhul()) {
...
...
// Pretend there is lots of code here
...
...
} else {
pseng();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!uhul() || wel || !frued() || !oulTrilma() && !a) {
pseng();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (tedtre() && !deop && nustre()) {
if (ochiss() < 0 && nustre()) {
if (nustre()) {
return true;
}
if (ha) {
return true;
}
if (cel) {
return true;
}
}
}
return false;
return (cel && ha || ochiss() < 0 || tedtre() && !deop) && nustre();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (deop && ochiss() > 0 && !ha || !cel || !tedtre() && ochiss() > 0 && !ha || !cel) {
if (!nustre()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (!uhir) {
bilMiesm();
}
if (!me && uhir) {
gonar();
} else if (iss == true && uhir && me) {
doaple();
}
if (mape == true && uhir && me && iss != true) {
isim();
} else if (uhir && me && iss != true && mape != true) {
granti();
}
{
if (!uhir) {
bilMiesm();
}
if (!me) {
gonar();
}
if (iss) {
doaple();
}
if (mape) {
isim();
}
granti();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: