This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!waroe() || cle < utfe && oss < hamtwu() && isnio()) {
...
...
// Pretend there is lots of code here
...
...
} else {
temo();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!isnio() || oss > hamtwu() || cle > utfe) && waroe()) {
temo();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (o && fuas()) {
if (deng <= ar) {
if (durt) {
return true;
}
}
if (ap) {
return true;
}
}
return false;
return ap && (durt || deng <= ar) || o && fuas();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!o && deng >= ar && !durt || !ap) {
if (!ap) {
if (!durt) {
return false;
}
if (deng >= ar) {
return false;
}
}
if (!fuas()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (!opri) {
lact();
} else if (ho == true && opri) {
palhec();
} else if (a == false && opri && ho != true) {
phoc();
} else if (snu == true && opri && ho != true && a != false) {
stese();
}
{
if (!opri) {
lact();
}
if (ho) {
palhec();
}
if (!a) {
phoc();
}
if (snu) {
stese();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: