This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (onme() <= 2 || qo || !(twus != 7) || siotho()) {
...
...
// Pretend there is lots of code here
...
...
} else {
qiss();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!siotho() && twus != 7 && !qo && onme() >= 2) {
qiss();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (e && tupre() && deng || gi && deng) {
if (gi && deng) {
if (deng) {
return true;
}
if (tupre()) {
return true;
}
}
if (har != 4) {
return true;
}
}
return false;
return (har != 4 || e) && (tupre() || gi) && deng;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!gi && !tupre() || !e && har == 4) {
if (!deng) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (he > a) {
fras();
}
if (jas == false && he < a) {
miongi();
}
if (!er && he < a && jas != false) {
jinra();
} else if (mopo == true && he < a && jas != false && er) {
hilNec();
}
{
if (he > a) {
fras();
}
if (!jas) {
miongi();
}
if (!er) {
jinra();
}
if (mopo) {
hilNec();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: