This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((cacphi() <= 5 || ke != 4) && brecs() && !(rousbi() <= 4)) {
...
...
// Pretend there is lots of code here
...
...
} else {
cocon();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (rousbi() <= 4 || !brecs() || ke == 4 && cacphi() >= 5) {
cocon();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (anfli() <= o && mecAclon() > wiuc() || !pran) {
if (fe) {
if (beit) {
return true;
}
}
}
return false;
return beit || fe || anfli() <= o && (mecAclon() > wiuc() || !pran);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (anfli() >= o && !fe && !beit) {
if (!beit) {
return false;
}
if (!fe) {
return false;
}
if (mecAclon() < wiuc()) {
return false;
}
if (pran) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ven != iosm) {
trean();
}
if (xol <= 5 && ven == iosm) {
riou();
}
if (e == false && ven == iosm && xol >= 5) {
coile();
}
if (!co && ven == iosm && xol >= 5 && e != false) {
hoshen();
}
{
if (ven != iosm) {
trean();
}
if (xol <= 5) {
riou();
}
if (!e) {
coile();
}
if (!co) {
hoshen();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: