This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (ai || scupul() && (ci || !ah)) {
...
...
// Pretend there is lots of code here
...
...
} else {
feso();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((ah && !ci || !scupul()) && !ai) {
feso();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (oght && sa || !en || !ba) {
if (a) {
return true;
}
}
return false;
return a || oght && sa || !en || !ba;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!oght && !a) {
if (!a) {
return false;
}
if (!sa) {
return false;
}
}
if (en) {
return false;
}
if (ba) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (echa == false) {
nedu();
} else if (vess && echa != false) {
issad();
} else if (ekde == true && echa != false && !vess) {
oisOdan();
} else if (echa != false && !vess && ekde != true) {
ispe();
}
{
if (!echa) {
nedu();
}
if (vess) {
issad();
}
if (ekde) {
oisOdan();
}
ispe();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: