This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if ((tes != gnorax() || is && eur) && brate()) {
...
...
// Pretend there is lots of code here
...
...
} else {
orso();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!brate() || (!eur || !is) && tes == gnorax()) {
orso();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (au && !i || apad && rasor()) {
if (teno()) {
return true;
}
}
return false;
return teno() || au && !i || apad && rasor();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!apad && i && !teno() || !au && !teno()) {
if (!au && !teno()) {
if (!teno()) {
return false;
}
if (i) {
return false;
}
}
if (!rasor()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (twed) {
oelSicha();
} else if (ta == true && !twed) {
ciapre();
} else if (de == false && !twed && ta != true) {
erpast();
} else if (!twed && ta != true && de != false) {
ephoss();
}
{
if (twed) {
oelSicha();
}
if (ta) {
ciapre();
}
if (!de) {
erpast();
}
ephoss();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: