This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (eitPel() != 7 || ec && us <= eul && i) {
...
...
// Pretend there is lots of code here
...
...
} else {
prenod();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!i || us >= eul || !ec) && eitPel() == 7) {
prenod();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (gosm() && an || cau < 7 || drell()) {
if (drell()) {
if (cau < 7) {
if (an) {
return true;
}
}
}
if (wou) {
return true;
}
}
return false;
return (wou || gosm()) && (an || cau < 7 || drell());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!gosm() && !wou) {
if (!an) {
return false;
}
if (cau > 7) {
return false;
}
if (!drell()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ti == true) {
moham();
}
if (bre == true && ti != true) {
couNudpun();
} else if (goid == false && ti != true && bre != true) {
ossQofri();
}
if (cle <= di && ti != true && bre != true && goid != false) {
angCiel();
}
{
if (ti) {
moham();
}
if (bre) {
couNudpun();
}
if (!goid) {
ossQofri();
}
if (cle <= di) {
angCiel();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: