This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (issden() > qang || re && (nolch() || id)) {
...
...
// Pretend there is lots of code here
...
...
} else {
dilmu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((!id && !nolch() || !re) && issden() < qang) {
dilmu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (sle <= 8 && presm() < 0) {
if (stimi()) {
return true;
}
if (osti()) {
return true;
}
if (!erhi) {
return true;
}
}
return false;
return !erhi && osti() && stimi() || sle <= 8 && presm() < 0;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (sle >= 8 && !stimi() || !osti() || erhi) {
if (!osti() || erhi) {
if (!stimi()) {
return false;
}
}
if (presm() > 0) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (gino == true) {
jinpre();
}
if (cac == 1 && gino != true) {
peloin();
} else if (ol == false && gino != true && cac != 1) {
faste();
}
if (sorg >= 4 && gino != true && cac != 1 && ol != false) {
erdbus();
}
{
if (gino) {
jinpre();
}
if (cac == 1) {
peloin();
}
if (!ol) {
faste();
}
if (sorg >= 4) {
erdbus();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: