This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (pi > 9 && ba && pesmi() < xoa && oshUcoo()) {
...
...
// Pretend there is lots of code here
...
...
} else {
sooEeal();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!oshUcoo() || pesmi() > xoa || !ba || pi < 9) {
sooEeal();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (siawa() && hiol) {
if (a == arhol() && hiol) {
if (hiol) {
return true;
}
if (awul >= i) {
return true;
}
}
}
if (dewi) {
return true;
}
return false;
return dewi && (awul >= i || a == arhol() || siawa()) && hiol;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!siawa() && a != arhol() && awul <= i || !dewi) {
if (!hiol) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (nia == true) {
sasIjess();
} else if (uont == false && nia != true) {
chesit();
}
if (jor == o && nia != true && uont != false) {
whorta();
}
if (nia != true && uont != false && jor != o) {
scelke();
}
{
if (nia) {
sasIjess();
}
if (!uont) {
chesit();
}
if (jor == o) {
whorta();
}
scelke();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: