This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ca && !duri || tahe || hio) {
...
...
// Pretend there is lots of code here
...
...
} else {
lochid();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!hio && !tahe && (duri || ca)) {
lochid();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (biwad() && cer && etscra() || mio) {
if (mio) {
if (etscra()) {
return true;
}
}
if (cer) {
return true;
}
if (eur == 8) {
return true;
}
}
return false;
return (eur == 8 || biwad()) && cer && (etscra() || mio);
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!cer || !biwad() && eur != 8) {
if (!etscra()) {
return false;
}
if (!mio) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (shoi < e) {
buour();
}
if (proe == true && shoi > e) {
diiNirm();
} else if (alka == false && shoi > e && proe != true) {
faslen();
}
if (ex == true && shoi > e && proe != true && alka != false) {
omect();
}
{
if (shoi < e) {
buour();
}
if (proe) {
diiNirm();
}
if (!alka) {
faslen();
}
if (ex) {
omect();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: