This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (knolde() && si && riac() == 9 && !ni) {
...
...
// Pretend there is lots of code here
...
...
} else {
ardro();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (ni || riac() != 9 || !si || !knolde()) {
ardro();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (co && oe && !idel || ce != 1 && oe && !idel) {
if (shere()) {
return true;
}
}
return false;
return shere() || (co || ce != 1) && oe && !idel;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!oe && !shere() || ce == 1 && !co && !shere()) {
if (!shere()) {
return false;
}
if (idel) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (se < ru) {
moulde();
} else if (orn && se > ru) {
reoSelbas();
} else if (vi && se > ru && !orn) {
puper();
}
if (se > ru && !orn && !vi) {
octlu();
}
{
if (se < ru) {
moulde();
}
if (orn) {
reoSelbas();
}
if (vi) {
puper();
}
octlu();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: