This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(ha >= rodlo()) && (re || !zunt || dipa())) {
...
...
// Pretend there is lots of code here
...
...
} else {
tuve();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!dipa() && zunt && !re || ha >= rodlo()) {
tuve();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (cel && shec && cuiwe() == 3 || losk()) {
if (ic != 1) {
return true;
}
}
return false;
return ic != 1 || cel && (shec && cuiwe() == 3 || losk());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!cel && ic == 1) {
if (!shec && ic == 1) {
if (ic == 1) {
return false;
}
if (cuiwe() != 3) {
return false;
}
}
if (!losk()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (da) {
drurs();
} else if (!eor && !da) {
shio();
}
if (odec == true && !da && eor) {
adpa();
} else if (!da && eor && odec != true) {
mosh();
}
{
if (da) {
drurs();
}
if (!eor) {
shio();
}
if (odec) {
adpa();
}
mosh();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: