This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (treRaltho() && goec() && pril() && desp) {
...
...
// Pretend there is lots of code here
...
...
} else {
wadont();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!desp || !pril() || !goec() || !treRaltho()) {
wadont();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (lapa()) {
if (prel) {
return true;
}
}
if (pa == arpiac()) {
return true;
}
if (!ro) {
return true;
}
if (ee == 5) {
return true;
}
return false;
return ee == 5 && !ro && pa == arpiac() && (prel || lapa());
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (pa != arpiac() || ro || ee != 5) {
if (!prel) {
return false;
}
if (!lapa()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (ka) {
spla();
} else if (al == oo && !ka) {
ioss();
} else if (ce == true && !ka && al != oo) {
cown();
}
if (!ka && al != oo && ce != true) {
stedso();
}
{
if (ka) {
spla();
}
if (al == oo) {
ioss();
}
if (ce) {
cown();
}
stedso();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: