This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (rira < cadca() && eulNir() && !dast && !staga()) {
...
...
// Pretend there is lots of code here
...
...
} else {
jaria();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (staga() || dast || !eulNir() || rira > cadca()) {
jaria();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (ho && olkul() || smou() && ioud) {
if (oosba() < 7) {
return true;
}
}
return false;
return oosba() < 7 || ho && olkul() || smou() && ioud;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!smou() && !olkul() && oosba() > 7 || !ho && oosba() > 7) {
if (!ho && oosba() > 7) {
if (oosba() > 7) {
return false;
}
if (!olkul()) {
return false;
}
}
if (!ioud) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (tede == true) {
ushmer();
} else if (pelo > iss && tede != true) {
nond();
}
if (odo == true && tede != true && pelo < iss) {
bouAmches();
}
if (cuo == true && tede != true && pelo < iss && odo != true) {
vieste();
}
{
if (tede) {
ushmer();
}
if (pelo > iss) {
nond();
}
if (odo) {
bouAmches();
}
if (cuo) {
vieste();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: