This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!a && lortur() && mo == 3 && phas()) {
...
...
// Pretend there is lots of code here
...
...
} else {
ranstu();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!phas() || mo != 3 || !lortur() || a) {
ranstu();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (prel && ded < ad && rass > wo) {
if (lostad()) {
if (i == hi) {
return true;
}
}
}
return false;
return i == hi || lostad() || prel && ded < ad && rass > wo;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!prel && !lostad() && i != hi) {
if (ded > ad && !lostad() && i != hi) {
if (i != hi) {
return false;
}
if (!lostad()) {
return false;
}
if (rass < wo) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (rean == spio) {
miace();
}
if (siar == true && rean != spio) {
spoRian();
}
if (cio > 7 && rean != spio && siar != true) {
conro();
} else if (stes == true && rean != spio && siar != true && cio < 7) {
prish();
}
{
if (rean == spio) {
miace();
}
if (siar) {
spoRian();
}
if (cio > 7) {
conro();
}
if (stes) {
prish();
}
}
Things to double-check in your solution:
== true and == false checks?else if, not just else.Related puzzles: