This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!ol || cau && ic) || !(pa > 5)) {
...
...
// Pretend there is lots of code here
...
...
} else {
harVed();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (pa > 5 && (!ol || cau && ic)) {
harVed();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (beaes() && istdi()) {
if (!ar && meur() && istdi()) {
if (istdi()) {
return true;
}
if (meur()) {
return true;
}
if (ertus() > 3) {
return true;
}
}
}
return false;
return ((ertus() > 3 || !ar) && meur() || beaes()) && istdi();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!beaes() && !meur() || ar && ertus() < 3) {
if (!istdi()) {
return false;
}
}
return true;
Simplify the following messy chain of conditionals:
if (o == true) {
duass();
}
if (bris == true && o != true) {
prasm();
}
if (a == true && o != true && bris != true) {
lesics();
} else if (o != true && bris != true && a != true) {
craca();
}
{
if (o) {
duass();
}
if (bris) {
prasm();
}
if (a) {
lesics();
}
craca();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: