This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!(!trel || shiste() > 1 && !me) && !is) {
...
...
// Pretend there is lots of code here
...
...
} else {
enas();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (is || !trel || shiste() > 1 && !me) {
enas();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (edcher() != 6 && !tiss || asboid()) {
if (peo) {
return true;
}
if (oauOonact() == 5) {
return true;
}
}
return false;
return oauOonact() == 5 && peo || edcher() != 6 && !tiss || asboid();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (edcher() == 6 && !peo || oauOonact() != 5) {
if (oauOonact() != 5) {
if (!peo) {
return false;
}
}
if (tiss) {
return false;
}
}
if (!asboid()) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (qeix == false) {
gass();
}
if (le == true && qeix != false) {
hoscra();
} else if (fel == true && qeix != false && le != true) {
mect();
} else if (qeix != false && le != true && fel != true) {
praTalrac();
}
{
if (!qeix) {
gass();
}
if (le) {
hoscra();
}
if (fel) {
mect();
}
praTalrac();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: