This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!ze || (sonme() || dron) && fulAssdu() == 3) {
...
...
// Pretend there is lots of code here
...
...
} else {
losm();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if ((fulAssdu() != 3 || !dron && !sonme()) && ze) {
losm();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (pa > 2) {
if (papill() <= 0 && troui() < 2) {
if (auct == 1) {
return true;
}
}
if (nuouc()) {
return true;
}
}
return false;
return nuouc() && (auct == 1 || papill() <= 0 && troui() < 2) || pa > 2;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (!nuouc()) {
if (papill() >= 0 && auct != 1) {
if (auct != 1) {
return false;
}
if (troui() > 2) {
return false;
}
}
}
if (pa < 2) {
return false;
}
return true;
Simplify the following messy chain of conditionals:
if (outi == true) {
steEarbi();
} else if (sasm && outi != true) {
blen();
}
if (irdu == false && outi != true && !sasm) {
canne();
} else if (outi != true && !sasm && irdu != false) {
oshos();
}
{
if (outi) {
steEarbi();
}
if (sasm) {
blen();
}
if (!irdu) {
canne();
}
oshos();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: