This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!osci && ilbio() == 3 && phist() && si) {
...
...
// Pretend there is lots of code here
...
...
} else {
birpa();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!si || !phist() || ilbio() != 3 || osci) {
birpa();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (he < 7 && swoEuoc() && whuSniop() > visro() && phan()) {
if (fa) {
return true;
}
}
return false;
return fa || he < 7 && swoEuoc() && whuSniop() > visro() && phan();
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (he > 7 && !fa) {
if (whuSniop() < visro() && !fa || !swoEuoc() && !fa) {
if (!fa) {
return false;
}
if (!phan()) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if (pept == true) {
frenan();
} else if (spol != 6 && pept != true) {
blanon();
}
if (ne <= 7 && pept != true && spol == 6) {
phleus();
}
if (pept != true && spol == 6 && ne >= 7) {
nenBaimi();
}
{
if (pept) {
frenan();
}
if (spol != 6) {
blanon();
}
if (ne <= 7) {
phleus();
}
nenBaimi();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: