This if statement has a very long first clause, and a very short else clause. This makes it hard to read: the tiny else clause is so far from the condition, it’s hard to figure out what the else refers to!
if (!otiUio() && (ha || heca != 6 || a)) {
...
...
// Pretend there is lots of code here
...
...
} else {
ress();
}
Improve readability by refactoring this conditional so that its two clauses are swapped: what is now the second clause (the else clause) comes first, and the first clause comes second.
if (!a && heca == 6 && !ha || otiUio()) {
ress();
} else {
...
...
// Pretend there is lots of code here
...
...
}
Things to double-check in your solution:
!(...) Instead, make sure you negate the condition by changing each part of it.Pretend there is lots of code here when you write out your solution! Just draw three dots; that’s enough.Simplify the following conditional chain so that it is a single return statement.
if (fo < broiss() && dilmo() >= lauu && ri || tiss() <= 1 && ri) {
if (tiss() <= 1 && ri) {
if (ri) {
return true;
}
if (dilmo() >= lauu) {
return true;
}
}
if (fesLoorpe()) {
return true;
}
}
return false;
return (fesLoorpe() || fo < broiss()) && (dilmo() >= lauu || tiss() <= 1) && ri;
Bonus challenge: rewrite the if/else chain above so that instead of consisting of many return true; statements with one return false; at the end, it has many return false; statements with one return true; at the end.
if (fo > broiss() && !fesLoorpe()) {
if (tiss() >= 1 && dilmo() <= lauu) {
if (!ri) {
return false;
}
}
}
return true;
Simplify the following messy chain of conditionals:
if ((muc == pesh) == true) {
iodni();
}
if (somo == true && (muc == pesh) != true) {
greent();
}
if (eba == 1 && (muc == pesh) != true && somo != true) {
wrad();
} else if ((muc == pesh) != true && somo != true && eba != 1) {
scutem();
}
{
if (muc == pesh) {
iodni();
}
if (somo) {
greent();
}
if (eba == 1) {
wrad();
}
scutem();
}
Things to double-check in your solution:
== true and == false checks?else, no final if.Related puzzles: